Gui: Qt5 fixes for MessageBox #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QTextEdit in QMessageBox workaround only works in Qt4. Instead use the Natron MessageBox (after some fixes).
acolwell
approved these changes
Apr 28, 2024
Gui/MessageBox.cpp
Outdated
| _imp->infoEdit = new QTextEdit; | ||
| _imp->infoEdit->setFocusPolicy(Qt::NoFocus); | ||
| _imp->infoEdit->setReadOnly(true); | ||
| _imp->infoEdit->setAlignment(Qt::AlignVCenter | Qt::AlignLeft); | ||
| _imp->infoEdit->append(message); | ||
| _imp->infoEdit->setWordWrapMode(QTextOption::WordWrap); | ||
| _imp->infoEdit->setHtml(message); |
There was a problem hiding this comment.
It looks the label path above will auto detect rich text or not. I wonder if this code should be something like the following to mimic that behavior.
if (Qt::mightBeRichText(message)) {
_imp->infoEdit->setHtml(message);
} else {
_imp->infoEdit->setPlainText(message);
}
There was a problem hiding this comment.
Sorry for the late reply, I will add check for rich text sometime tomorrow after work.
There was a problem hiding this comment.
ohh, forgot about this one, sorry. Will add fix as soon as I'm in front of my dev machine (~1h).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QTextEdit in QMessageBox workaround only works in Qt4. Instead use the Natron MessageBox (after some fixes).
Tested on Windows 10 with Qt 5.15.13.