Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLT-0075 Order Domain changes #52

Merged
merged 22 commits into from
Dec 11, 2024
Merged

MLT-0075 Order Domain changes #52

merged 22 commits into from
Dec 11, 2024

Conversation

anotheroneofthese
Copy link
Collaborator

Replaces Receiver with two new fields in the Order model

@anotheroneofthese anotheroneofthese marked this pull request as ready for review November 29, 2024 13:18
@anotheroneofthese anotheroneofthese changed the title MLT-0075 Remove Receiver, add new fields to Order domain model MLT-0075 Order Domain changes Dec 2, 2024
@MormonJesus69420
Copy link
Collaborator

I dunno if you and Tom have discussed it, but shouldn't the person in the address be nullable as well?

@anotheroneofthese
Update Address -> SynQ differently
65d621f 
WLS -> SynQ

- contactPerson -> Contact Person
- recipient -> Address Line 1
- addressLine1 -> Address Line 2
- addressLine2 -> Address Line 3
MormonJesus69420
MormonJesus69420 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@MormonJesus69420 MormonJesus69420 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, why are ports in compose file written in quotes now?

EDIT: oh okay so apparently anything in YAML written as xx:xx will be parsed as a base 60 number if values are under 60, weird but okay

@anotheroneofthese
Copy link
Collaborator Author

New best practice, according to https://stackoverflow.com/questions/58810789/quotes-on-docker-compose-yml-ports-make-any-difference
image
Docker doesn't seem to reflect this in their specification anymore. They might have changed it, although there seems to be questions floating around where the solution usually is stringifying the ports

@anotheroneofthese anotheroneofthese merged commit 4cdddca into main Dec 11, 2024
5 checks passed
@MormonJesus69420
Copy link
Collaborator

image
https://yaml.org/type/float.html

Yeah it is still recommended practice to write HOST:CONTAINER as strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MormonJesus69420 MormonJesus69420 MormonJesus69420 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anotheroneofthese @MormonJesus69420