Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Test Improvements #33

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Controller Test Improvements #33

merged 6 commits into from
Sep 6, 2024

Conversation

anotheroneofthese
Copy link
Collaborator

A small thing on the side I have been preparing until all the endpoints were merged into main. This contains tests for the GET, UPDATE, and DELETE endpoints.

Awaiting endpoint
- Extend and fix update order happy test
- Add TODO related to get order functionality
Fix second DELETE test and handle merge from main
Copy link
Collaborator

@MormonJesus69420 MormonJesus69420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far, and good on noticing the GET endpoint returning a pure Order object. Makes me fell silly for missing that in previous review

- Remove abbreviations for test payloads
- clientName -> client
@anotheroneofthese anotheroneofthese merged commit 26a044e into main Sep 6, 2024
5 checks passed
@anotheroneofthese anotheroneofthese deleted the controller-tests branch October 22, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants