Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLT-0043 Update Order (PUT) endpoint #31

Merged
merged 15 commits into from
Aug 29, 2024

Update src/main/kotlin/no/nb/mlt/wls/order/service/OrderService.kt

5118797
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

MLT-0043 Update Order (PUT) endpoint #31

Update src/main/kotlin/no/nb/mlt/wls/order/service/OrderService.kt
5118797
Select commit
Loading
Failed to load commit list.
GitHub Actions / JUnit Tests succeeded Aug 29, 2024 in 1s

37 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
target/surefire-reports/TEST-no.nb.mlt.wls.order.controller.OrderControllerTest.xml 5✅ 19s
target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelConversionTest.xml 3✅ 5ms
target/surefire-reports/TEST-no.nb.mlt.wls.order.service.OrderServiceTest.xml 13✅ 476ms
target/surefire-reports/TEST-no.nb.mlt.wls.product.controller.ProductControllerTest.xml 5✅ 991ms
target/surefire-reports/TEST-no.nb.mlt.wls.product.model.ProductModelConversionTest.xml 3✅ 3ms
target/surefire-reports/TEST-no.nb.mlt.wls.product.service.ProductServiceTest.xml 8✅ 94ms

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.controller.OrderControllerTest.xml

5 tests were completed in 19s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.controller.OrderControllerTest 5✅ 19s

✅ no.nb.mlt.wls.order.controller.OrderControllerTest

✅ createOrder with duplicate payload returns OK
✅ createOrder payload with different data but same ID returns DB entry
✅ createOrder with valid payload creates order
✅ createOrder handles SynQ error
✅ createOrder where SynQ says it's a duplicate returns OK

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.model.OrderModelConversionTest.xml

3 tests were completed in 5ms with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.model.OrderModelConversionTest 3✅ 5ms

✅ no.nb.mlt.wls.order.model.OrderModelConversionTest

✅ order converts to API payload
✅ API payload converts to order
✅ order converts to SynQ payload

✅ target/surefire-reports/TEST-no.nb.mlt.wls.order.service.OrderServiceTest.xml

13 tests were completed in 476ms with 13 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.order.service.OrderServiceTest 13✅ 476ms

✅ no.nb.mlt.wls.order.service.OrderServiceTest

✅ update existing order with no errors returns ok
✅ save called when db is down is handled gracefully
✅ save called with payload missing orderId throws
✅ update order which doesn't exist in synq throws
✅ save with no errors returns created order
✅ save called with Order that SynQ says exists throws
✅ update order which you don't own throws
✅ update order which is being processed is conflict
✅ save called when SynQ fails is handled gracefully
✅ save called with payload missing hostOrderId throws
✅ update order which doesn't exist throws
✅ save with payload missing product lines throws
✅ save when order exists throws

✅ target/surefire-reports/TEST-no.nb.mlt.wls.product.controller.ProductControllerTest.xml

5 tests were completed in 991ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.product.controller.ProductControllerTest 5✅ 991ms

✅ no.nb.mlt.wls.product.controller.ProductControllerTest

✅ createProduct with valid payload creates product
✅ createProduct with duplicate payload returns OK
✅ createProduct handles SynQ error
✅ createProduct where SynQ says it's a duplicate returns OK
✅ createProduct payload with different data but same ID returns DB entry

✅ target/surefire-reports/TEST-no.nb.mlt.wls.product.model.ProductModelConversionTest.xml

3 tests were completed in 3ms with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.product.model.ProductModelConversionTest 3✅ 3ms

✅ no.nb.mlt.wls.product.model.ProductModelConversionTest

✅ product converts to SynQ payload
✅ product converts to API payload
✅ API payload converts to product

✅ target/surefire-reports/TEST-no.nb.mlt.wls.product.service.ProductServiceTest.xml

8 tests were completed in 94ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
no.nb.mlt.wls.product.service.ProductServiceTest 8✅ 94ms

✅ no.nb.mlt.wls.product.service.ProductServiceTest

✅ save called with payload missing description throws
✅ save called with payload missing productCategory throws
✅ save with no errors returns created product
✅ save called with payload missing hostId throws
✅ save called with existing product, returns existing product
✅ save when DB fails handles it gracefully
✅ save called with product that SynQ says exists, returns without a product
✅ save when synq fails handles it gracefully