Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLT-0040 More reactive handling #27

Merged
merged 7 commits into from
Aug 16, 2024
Merged

MLT-0040 More reactive handling #27

merged 7 commits into from
Aug 16, 2024

Conversation

anotheroneofthese
Copy link
Collaborator

This PR refactors the codebase to achieve even further reactive handling. It makes the following improvements:

  • Properly throw exceptions when the service times out
  • Unify the handling of errors from SynQ between all services
  • Streamline exception handling using more reactive code

MormonJesus69420
MormonJesus69420 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@MormonJesus69420 MormonJesus69420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anotheroneofthese anotheroneofthese merged commit 5781a4d into main Aug 16, 2024
5 checks passed
@anotheroneofthese anotheroneofthese deleted the mlt-0040-more-reactive branch September 30, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MormonJesus69420 MormonJesus69420 MormonJesus69420 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anotheroneofthese @MormonJesus69420