Fix errors with item moving logic

NationalLibraryOfNorway · Oct 9, 2024 · 98113d5 · 98113d5
1 parent 82b2684
commit 98113d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/kotlin/no/nb/mlt/wls/domain/WLSService.kt b/src/main/kotlin/no/nb/mlt/wls/domain/WLSService.kt
@@ -71,9 +71,9 @@ class WLSService(
             throw ValidationException("Location can not be blank")
         }
         val item = getItem(hostName, hostId) ?: throw ItemNotFoundException("Item with id '$hostId' does not exist for '$hostName'")
-        itemRepository.moveItem(item.hostId, item.hostName, quantity, location)
-        inventoryNotifier.itemChanged(item)
-        return item
+        val movedItem = itemRepository.moveItem(item.hostId, item.hostName, quantity, location)
+        inventoryNotifier.itemChanged(movedItem)
+        return movedItem
     }
 
     override suspend fun createOrder(orderDTO: CreateOrderDTO): Order {

diff --git a/src/test/kotlin/no/nb/mlt/wls/domain/WLSServiceTest.kt b/src/test/kotlin/no/nb/mlt/wls/domain/WLSServiceTest.kt
@@ -4,6 +4,7 @@ import io.mockk.clearAllMocks
 import io.mockk.coEvery
 import io.mockk.coJustRun
 import io.mockk.coVerify
+import io.mockk.every
 import io.mockk.mockk
 import kotlinx.coroutines.test.runTest
 import no.nb.mlt.wls.domain.model.Environment
@@ -133,6 +134,7 @@ class WLSServiceTest {
             )
         coEvery { itemRepoMock.getItem(any(), any()) } returns testItem
         coEvery { itemRepoMock.moveItem(any(), any(), any(), any()) } returns expectedItem
+        every { inventoryNotifierMock.itemChanged(any()) } answers {}
 
         val cut = WLSService(itemRepoMock, orderRepoMock, storageSystemRepoMock, inventoryNotifierMock)
         runTest {