Migrate to dummy-synq for integration tests

docker/compose.yaml

@@ -45,3 +45,9 @@ services:
     command: start-dev --import-realm
     volumes:
       - ./keycloak/import:/opt/keycloak/data/import
+
+  dummy-synq:
+    image: harbor.nb.no/mlt/dummy-synq:main
+    restart: always
+    ports:
+      - 8181:8181

src/main/resources/application.yml

@@ -71,7 +71,7 @@ spring:
 # Set a dummycatalog base path to SynQ for testing purposes
 synq:
   path:
-    base: http://dummycatalog.nb.no/synq/resources
+    base: http://localhost:8181/synq/resources
 
 ---
 

src/test/kotlin/no/nb/mlt/wls/TestcontainerInitializer.kt

@@ -3,22 +3,24 @@ package no.nb.mlt.wls
 import org.springframework.boot.test.util.TestPropertyValues
 import org.springframework.context.ApplicationContextInitializer
 import org.springframework.context.ConfigurableApplicationContext
+import org.testcontainers.containers.GenericContainer
 import org.testcontainers.containers.MongoDBContainer
 import org.testcontainers.lifecycle.Startables
 import org.testcontainers.utility.DockerImageName
 
 class TestcontainerInitializer : ApplicationContextInitializer<ConfigurableApplicationContext> {
     companion object {
         val MongoContainer = MongoDBContainer(DockerImageName.parse("mongo:4.4.22"))
+        val DummySynqContainer = GenericContainer(DockerImageName.parse("harbor.nb.no/mlt/dummy-synq:main"))
 
         init {
-            Startables.deepStart(MongoContainer).join()
+            Startables.deepStart(MongoContainer, DummySynqContainer).join()
         }
     }
 
     override fun initialize(applicationContext: ConfigurableApplicationContext) {
         TestPropertyValues.of("spring.data.mongodb.uri=" + MongoContainer.replicaSetUrl).applyTo(applicationContext)
         // Temporary solution while we are working on implementing a test container for SynQ
-        TestPropertyValues.of("synq.path.base=http://dummycatalog.nb.no/synq/resources").applyTo(applicationContext)
+        TestPropertyValues.of("synq.path.base=http://localhost:8181/synq/resources").applyTo(applicationContext)
     }
 }

src/test/kotlin/no/nb/mlt/wls/product/controller/ProductControllerTest.kt

@@ -1,6 +1,5 @@
 package no.nb.mlt.wls.product.controller
 
-import com.ninjasquad.springmockk.MockkBean
 import io.mockk.every
 import io.mockk.junit5.MockKExtension
 import no.nb.mlt.wls.EnableTestcontainers
@@ -26,14 +25,12 @@ import org.springframework.boot.test.context.SpringBootTest.WebEnvironment.RANDO
 import org.springframework.data.mongodb.repository.config.EnableMongoRepositories
 import org.springframework.http.HttpStatus
 import org.springframework.http.MediaType
-import org.springframework.http.ResponseEntity
 import org.springframework.security.test.context.support.WithMockUser
 import org.springframework.security.test.web.reactive.server.SecurityMockServerConfigurers.csrf
 import org.springframework.test.web.reactive.server.WebTestClient
 import org.springframework.test.web.reactive.server.expectBody
 import org.springframework.web.client.HttpClientErrorException
 import org.springframework.web.server.ServerErrorException
-import java.net.URI
 
 @EnableTestcontainers
 @TestInstance(PER_CLASS)
@@ -42,11 +39,9 @@ import java.net.URI
 @EnableMongoRepositories("no.nb.mlt.wls")
 @SpringBootTest(webEnvironment = RANDOM_PORT)
 class ProductControllerTest(
-    @Autowired val repository: ProductRepository
+    @Autowired val repository: ProductRepository,
+    @Autowired val synqProductService: SynqProductService
 ) {
-    @MockkBean
-    private lateinit var synqProductService: SynqProductService
-
     private lateinit var webTestClient: WebTestClient
 
     @BeforeEach
@@ -64,10 +59,6 @@ class ProductControllerTest(
     @Test
     @WithMockUser
     fun `createProduct with valid payload creates product`() {
-        every {
-            synqProductService.createProduct(any())
-        } returns ResponseEntity.created(URI.create("")).build()
-
         webTestClient
             .mutateWith(csrf())
             .post()
@@ -124,10 +115,6 @@ class ProductControllerTest(
     @Test
     @WithMockUser
     fun `createProduct where SynQ says it's a duplicate returns OK`() {
-        every {
-            synqProductService.createProduct(any())
-        } returns ResponseEntity.ok().build()
-
         webTestClient
             .mutateWith(csrf())
             .post()