-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-1042: Read language codes for initialized files from .env #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebeauguitte
requested changes
Sep 6, 2023
pierrebeauguitte
requested changes
Sep 11, 2023
…ditional language ISO-692-2 'nno' and undetermined 'und'
Co-authored-by: pierrebeauguitte <[email protected]>
Co-authored-by: pierrebeauguitte <[email protected]>
fredrikmonsen
force-pushed
the
feature/TT-1042
branch
from
September 12, 2023 11:59
5b83aef
to
2d2122d
Compare
pierrebeauguitte
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the application read which language codes to read from in the metadata_extract.data.txt json files.
Additionally, this commit changes language code to ISO-692-2, and separates 'nob' and 'nno'. Furthermore, the Norwegian Nynorsk word lists have been expanded.
Undetermined language code 'und' is added with universally used keywords such as 'issn' and 'isbn'