Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove winapi as dependency #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sn99
Copy link

@sn99 sn99 commented Jan 31, 2023

The changes include, Migrating from winapi to windows-sys: winapi is no longer maintained in favor of windows-rs which is provided by Microsoft itself. It should provide more robustness against future windows upgrade and better compile and runtime guarantees.

This is the continuation of #97

  • You were right about cargo profile changes, they are overwritten by end binary
  • I have removed any clippy changes, they should have been a separate pull
  • I had no idea about global .gitignore, so that's a pretty good thing to learn
  • I have put the types in mod.rs as public
  • I did not undertsand your comment about removing the global HOOK, aren't we modifying it at set_key_hook & set_mouse_hook

@Narsil
Copy link
Owner

Narsil commented Jan 31, 2023

I did not undertsand your comment about removing the global HOOK, aren't we modifying it at set_key_hook & set_mouse_hook

You moved it's location (or the diff wasn't smart enough to put it close enough). It's all good.

@Narsil
Copy link
Owner

Narsil commented Jan 31, 2023

Thanks for the big refacto.

This PR looks much cleaner to me, as the type changes do stand out much more than they used to.
They still feel weird, but are necessary since they are differences in the original crates..

As I mentioned in the previous PR, I'm unlikely to merge before having checked extensively this (which I can't promise will happen any time soon).
If anyone happens to take this PR out for a spin and it works (or has bugs) it would be nice to share here (if many people report it's working, I'll take that as a good sign, and maybe not test as much and merge earlier).

@sn99
Copy link
Author

sn99 commented Feb 1, 2023

Nice, thanks for pointing out my mistakes, it has indeed idk how to say useful for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants