Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec 2.14.1 → 3.3.0 (major) #84

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 13, 2024

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.14.1 → 3.3.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.37.1 → 1.69.2) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.6.2 → 2.9.0) · Repo · Changelog

Release Notes

2.9.0

What's Changed

  • Fix C implementation of script_safe escaping to not confuse some other 3 wide characters with \u2028 and \u2029.
    e.g. JSON.generate(["倩", "瀨"], script_safe: true) would generate the wrong JSON.
  • JSON.dump(object, some_io) now write into the IO in chunks while previously it would buffer the entire JSON before writing.
  • JSON::GeneratorError now has a #invalid_object attribute, making it easier to understand why an object tree cannot be serialized.
  • Numerous improvements to the JRuby extension.

Full Changelog: v2.8.2...v2.9.0

2.8.2

What's Changed

  • JSON.load_file: explictly load the file as UTF-8

Full Changelog: v2.8.1...v2.8.2

2.8.1

  • Fix the java version of the package to include the extension implementation. Only concerns JRuby.

Full Changelog: v2.8.0...v2.8.1

2.8.0

What's Changed

  • Emit a deprecation warning when JSON.load create custom types without the create_additions option being explictly enabled.
    • Prefer to use JSON.unsafe_load(string) or JSON.load(string, create_additions: true).
  • Emit a deprecation warning when serializing valid UTF-8 strings encoded in ASCII_8BIT aka BINARY.
  • Bump required Ruby version to 2.7.
  • Add support for optionally parsing trailing commas, via allow_trailing_comma: true, which in cunjunction with the
    pre-existing support for comments, make it suitable to parse jsonc documents.
  • Many performance improvements to JSON.parse and JSON.load, up to 1.7x faster on real world documents.
  • Some minor performance improvements to JSON.dump and JSON.generate.

Parsing performance

Parsing performance is improved by 50-70% on realistic benchmarks, and even more on micro-benchmarks: https://gist.github.com/casperisfine/cf4b3a0594fae24b7d0eb93daaf3841a

== Parsing activitypub.json (58160 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
          json 2.7.2   638.000 i/100ms
                  oj   798.000 i/100ms
          Oj::Parser   948.000 i/100ms
           rapidjson   631.000 i/100ms
Calculating -------------------------------------
          json 2.7.2      6.423k (± 1.3%) i/s  (155.70 μs/i) -     32.538k in   5.067149s
                  oj      7.989k (± 1.0%) i/s  (125.17 μs/i) -     40.698k in   5.094544s
          Oj::Parser      9.472k (± 1.3%) i/s  (105.58 μs/i) -     47.400k in   5.005119s
           rapidjson      6.354k (± 1.1%) i/s  (157.37 μs/i) -     32.181k in   5.064962s

Comparison:
json 2.8.0: 9510.0 i/s
Oj::Parser: 9471.9 i/s - same-ish: difference falls within error
oj: 7989.4 i/s - 1.19x slower
json 2.7.2: 6422.5 i/s - 1.48x slower
rapidjson: 6354.5 i/s - 1.50x slower

== Parsing twitter.json (567916 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
json 2.7.2 52.000 i/100ms
oj 64.000 i/100ms
Oj::Parser 76.000 i/100ms
rapidjson 57.000 i/100ms
Calculating -------------------------------------
json 2.7.2 526.860 (± 3.8%) i/s (1.90 ms/i) - 2.652k in 5.042680s
oj 631.234 (± 1.7%) i/s (1.58 ms/i) - 3.200k in 5.070973s
Oj::Parser 764.354 (± 3.5%) i/s (1.31 ms/i) - 3.876k in 5.077736s
rapidjson 579.085 (± 2.8%) i/s (1.73 ms/i) - 2.907k in 5.024620s

Comparison:
json 2.8.0: 884.0 i/s
Oj::Parser: 764.4 i/s - 1.16x slower
oj: 631.2 i/s - 1.40x slower
rapidjson: 579.1 i/s - 1.53x slower
json 2.7.2: 526.9 i/s - 1.68x slower

== Parsing citm_catalog.json (1727030 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
json 2.7.2 30.000 i/100ms
oj 35.000 i/100ms
Oj::Parser 45.000 i/100ms
rapidjson 40.000 i/100ms
Calculating -------------------------------------
json 2.7.2 304.584 (± 3.3%) i/s (3.28 ms/i) - 1.530k in 5.029021s
oj 358.572 (± 0.8%) i/s (2.79 ms/i) - 1.820k in 5.076123s
Oj::Parser 450.643 (± 3.1%) i/s (2.22 ms/i) - 2.295k in 5.098150s
rapidjson 395.304 (± 1.5%) i/s (2.53 ms/i) - 2.000k in 5.060537s

Comparison:
json 2.8.0: 449.8 i/s
Oj::Parser: 450.6 i/s - same-ish: difference falls within error
rapidjson: 395.3 i/s - 1.14x slower
oj: 358.6 i/s - 1.25x slower
json 2.7.2: 304.6 i/s - 1.48x slower

Full Changelog: v2.7.3...v2.8.0

2.7.6

  • Fix a regression in JSON.generate when dealing with Hash keys that are string subclasses, call to_json on them.

Full Changelog: v2.7.5...v2.7.6

2.7.5

What's Changed

  • Fix a memory leak when #to_json methods raise an exception.
  • Gracefully handle formatting configs being set to nil instead of "".
  • Workaround another issue caused by conflicting versions of both json_pure and json being loaded.

Full Changelog: v2.7.4...v2.7.5

2.7.4

What's Changed

  • Workaround a bug in 3.4.8 and older rubygems/rubygems#6490.
    This bug would cause some gems with native extension to fail during compilation.
  • Workaround different versions of json and json_pure being loaded (not officially supported).
  • Make json_pure Ractor compatible.

Full Changelog: v2.7.3...v2.7.4

2.7.3

What's Changed

  • Numerous performance optimizations in JSON.generate and JSON.dump (up to 2 times faster).
  • Limit the size of ParserError exception messages, only include up to 32 bytes of the unparseable source.
  • Fix json-pure's Object#to_json to accept non state arguments
  • Fix multiline comment support in json-pure.
  • Fix JSON.parse to no longer mutate the argument encoding when passed an ASCII-8BIT string.
  • Fix String#to_json to raise on invalid encoding in json-pure.
  • Delete code that was based on CVTUTF.
  • Use the pure-Ruby generator on TruffleRuby.
  • Fix strict mode in json-pure to not break on Integer.

JSON.dump Performance

JSON.dump is now much faster, and on par or faster than alternative implementations:

== Encoding citm_catalog.json (500298 bytes)
ruby 3.4.0preview2 (2024-10-07 master 32c733f57b) +YJIT +PRISM [arm64-darwin23]
Warming up --------------------------------------
        json (2.7.3)   123.000 i/100ms
                  oj   124.000 i/100ms
Calculating -------------------------------------
        json (2.7.3)      1.312k (± 1.8%) i/s  (761.91 μs/i) -      6.642k in   5.062192s
                  oj      1.278k (± 2.0%) i/s  (782.35 μs/i) -      6.448k in   5.046587s

Comparison:
json (2.7.2): 884.0 i/s
json (2.7.3): 1312.5 i/s - 1.48x faster
oj: 1278.2 i/s - 1.45x faster

== Encoding twitter.json (466906 bytes)
ruby 3.4.0preview2 (2024-10-07 master 32c733f57b) +YJIT +PRISM [arm64-darwin23]
Warming up --------------------------------------
        json (2.7.3)   213.000 i/100ms
                  oj   222.000 i/100ms
Calculating -------------------------------------
        json (2.7.3)      2.140k (± 2.8%) i/s  (467.19 μs/i) -     10.863k in   5.079099s
                  oj      2.303k (± 3.2%) i/s  (434.27 μs/i) -     11.544k in   5.018239s

Comparison:
        json (2.7.2):     1250.5 i/s
                  oj:     2302.7 i/s - 1.84x  faster
        json (2.7.3):     2140.5 i/s - 1.71x  faster

Full Changelog: ruby/json@v2.7.2...v2.7.3

2.7.2

What's Changed

  • Use rb_sym2str instead of SYM2ID by @jhawthorn in #561
  • Fix memory leak when exception is raised during JSON generation by @peterzhu2118 in #574
  • Remove references to "19" methods in JRuby by @headius in #576
  • Make OpenStruct support as optional by @hsbt in #565
  • Autoload JSON::GenericObject to avoid require ostruct warning in Ruby 3.4 by @tompng in #577
  • Warn to install ostruct if json couldn't load it by @hsbt in #578

New Contributors

Full Changelog: v2.7.1...v2.7.2

2.7.1

What's Changed

Improved

Fixed

Misc

New Contributors

Full Changelog: v2.7.0...v2.7.1

2.7.0

What's Changed

Improved

  • Perf. improvements to Hash#to_json in pure implementation generator. by @vipulnsward in #203
  • Remove unnecessary initialization of create_id in JSON.parse() by @Watson1978 in #454

Added

Fixed

Compatibility changes

  • JRuby requires a minimum of Java 8 by @headius in #516
  • Rename JSON::ParseError to JSON:ParserError by @dalizard in #530
  • Removed code for Ruby 1.8 by @hsbt in #540
  • alias_method is private on Ruby 2.3 and 2.4 by @hsbt in #541
  • remove_method of Module is private at Ruby 2.3 and 2.4 by @hsbt in #544
  • [jruby] avoid using deprecated BigDecimal.new by @kares in #546
  • Always indent even if empty by @headius in #517

Misc

  • Update CI matrix by @hsbt in #521
  • Add missing changelog entries for 1.8.5 and 1.8.6 by @r7kamura in #520
  • Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows by @MSP-Greg in #491
  • Skip unsupported test on JRuby by @nobu in #532
  • Skip BigDecimal tests when it's missing to load by @hsbt in #533
  • Simplify by @nobu in #531
  • Load extension ('json/ext') consistently in test_ext by @aeroastro in #536
  • Use test-unit-ruby-core gem by @hsbt in #539
  • [CI] Add Windows mswin job by @MSP-Greg in #545
  • Exclude truffleruby-head from Actions by @hsbt in #551
  • tests/ractor_test.rb: make assert_separately available by @lucaskanashiro in #506
  • Added changes for 2.7.0 and restore entries to 2.6.3 and 2.6.2 by @hsbt in #552

New Contributors

Full Changelog: v2.6.3...v2.7.0

2.6.3

What's Changed

  • bugfix json/pure mixing escaped with literal unicode raises Encoding::CompatibilityError by @notEthan in #483
  • Stop including the parser source LINE in exceptions by @casperisfine in #470

New Contributors

Full Changelog: v2.6.2...v2.6.3

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parallel (indirect, 1.22.1 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 44 commits:

↗️ parser (indirect, 3.1.2.1 → 3.3.6.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.6.0 → 2.9.3) · Repo · Changelog

Release Notes

2.9.3 (from changelog)

Fixed

  • fixed positive lookbehinds with character ">" being treated as named groups

2.9.2 (from changelog)

Fixed

  • made the MFA requirement for changes to this gem visible on rubygems

2.9.1 (from changelog)

Fixed

  • fixed unnecessary $LOAD_PATH searches at load time

2.9.0 (from changelog)

Added

  • all expressions now respond to #negative? / #negated?
    • previously only sets, props, and posix classes did
  • implemented #negative? / #negated? for more applicable expressions
    • \B, \D, \H, \S, \W, (?!...), (?<!...)

Fixed

  • fixed missing support for grapheme cluster break unicode properties
    • e.g. /\p{Grapheme_Cluster_Break=Extend}/

2.8.3 (from changelog)

Fixed

  • fixed scanner errors for insignificant leading zeros in numerical group refs
    • e.g. (a)\k<01>, (a)\g<-01>, (a)?(?(01)b|c)
    • thanks to Markus Schirp for the report

2.8.2 (from changelog)

Fixed

  • handle a corner case where parsing redundant number escapes raised an error
    • e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99
    • thanks to Markus Schirp for the report

2.8.1 (from changelog)

Fixed

  • support for extpict unicode property, added in Ruby 2.6
  • support for 10 unicode script/block properties added in Ruby 3.2

2.8.0 (from changelog)

Added

  • Regexp::Expression::Shared#ends_at
    • e.g. parse(/a +/x)[0].ends_at # => 3
    • e.g. parse(/a +/x)[0].ends_at(include_quantifier = false) # => 1
  • Regexp::Expression::Shared#{capturing?,comment?}
    • previously only available on capturing and comment groups
  • Regexp::Expression::Shared#{decorative?}
    • true for decorations: comment groups as well as comments and whitespace in x-mode
  • Regexp::Expression::Shared#parent
  • new format argument :original for Regexp::Expression::Base#to_s
    • includes decorative elements between node and its quantifier
    • e.g. parse(/a (?#comment) +/x)[0].to_s(:original) # => "a (?#comment) +"
    • using it is not needed when calling Root#to_s as Root can't be quantified
  • support calling Subexpression#{each_expression,flat_map} with a one-argument block
    • in this case, only the expressions are passed to the block, no indices
  • support calling test methods at Expression class level
    • capturing?, comment?, decorative?, referential?, terminal?
    • e.g. Regexp::Expression::CharacterSet.terminal? # => false

Fixed

  • Regexp::Expression::Shared#full_length with whitespace before quantifier
    • e.g. parse(/a +/x)[0].full_length used to yield 2, now it yields 3
  • Subexpression#to_s output with children with whitespace before their quantifier
    • e.g. parse(/a + /x).to_s used to yield "a+ ", now it yields "a + "
    • calling #to_s on sub-nodes still omits such decorative interludes by default
      • use new #to_s format :original to include it
      • e.g. parse(/a + /x)[0].to_s(:original) # => "a +"
  • fixed Subexpression#te behaving differently from other expressions
    • only Subexpression#te used to include the quantifier
    • now #te is the end index without quantifier, as for other expressions
  • fixed NoMethodError when calling #starts_at or #ts on empty sequences
    • e.g. Regexp::Parser.parse(/|/)[0].starts_at
    • e.g. Regexp::Parser.parse(/[&&]/)[0][0].starts_at
  • fixed nested comment groups breaking local x-options
    • e.g. in /(?x:(?#hello)) /, the x-option wrongly applied to the whitespace
  • fixed nested comment groups breaking conditionals
    • e.g. in /(a)(?(1)b|c(?#hello)d)e/, the 2nd conditional branch included "e"
  • fixed quantifiers after comment groups being mis-assigned to that group
    • e.g. in /a(?#foo){3}/ (matches 'aaa')
  • fixed Scanner accepting two cases of invalid Regexp syntax
    • unmatched closing parentheses ()) and k-backrefs with number 0 (\k<0>)
    • these are a SyntaxError in Ruby, so could only be passed as a String
    • they now raise a Regexp::Scanner::ScannerError
  • fixed some scanner errors not inheriting from Regexp::Scanner::ScannerError
  • reduced verbosity of inspect / pretty print output

2.7.0 (from changelog)

Added

  • Regexp::Lexer.lex now streams tokens when called with a block
    • it can now take arbitrarily large input, just like Regexp::Scanner
    • this also slightly improves Regexp::Parser.parse performance
    • note: Regexp::Parser.parse still does not and will not support streaming
  • improved performance of Subexpression#each_expression
  • minor improvements to Regexp::Scanner performance
  • overall improvement of parse performance: about 10% for large Regexps

Fixed

  • parsing of octal escape sequences in sets, e.g. [\141]

2.6.2 (from changelog)

Fixed

  • fixed SystemStackError when cloning recursive subexpression calls
    • e.g. Regexp::Parser.parse(/a|b\g<0>/).dup

2.6.1 (from changelog)

Fixed

  • fixed scanning of two negative lookbehind edge cases
    • (?<!x)y> used to raise a ScannerError
    • (?<!x>)y used to be misinterpreted as a named group
    • thanks to Sergio Medina for the report

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.23.0 → 1.37.0) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ruby-progressbar (indirect, 1.11.0 → 1.13.0) · Repo · Changelog

Release Notes

1.13.0 (from changelog)

Add

  • Ability To Allow Different Projectors To Be Used For Time Estimates
  • Concept Of A Projector
  • Ability To Access Progress Bar Instance Using Enumerator Refinement

Remove

  • smoothing Option

Change

  • Issue Caused By Ruby Bug

1.12.0 (from changelog)

Add

  • Ability To Swap Out Running Average Calculators
  • running_average_rate As Configuration Option
  • Wall Clock Time To Completion To The Format Elements

Change

  • Rename Running Average Calculator To Smoothed Average Calculator
  • Rename smoothing To running_average_rate
  • Rename smoothing_factor To rate
  • Allow Timer's Elapsed Seconds To Calculate Even If Not Started

Does any of this look wrong? Please let us know.

↗️ unicode-display_width (indirect, 2.3.0 → 3.1.2) · Repo · Changelog

Release Notes

3.1.2 (from changelog)

  • Performance improvements

3.1.1 (from changelog)

  • Performance improvements

3.1.0 (from changelog)

Improve Emoji support:

  • Emoji modes: Differentiate between well-formed Emoji (:possible) and any ZWJ/modifier sequence (:all). The latter is more common and more efficient to implement.
  • Unify rgi_{fqe,mqe,uqe} options to just :rgi to keep things simpler (corresponds to the former :rgi_uqe option). Most terminals that want to support the RGI set will probably want to catch Emoji sequences with missing VS16s.
  • Add new :all_no_vs16 and :rgi_at modes to be able to support some terminals that needs these quirks
  • Add alias emoji: :auto for emoji: true and emoji: :none for emoji: false
  • :auto mode: Only consider terminal cells when recommending Emoji support level (Emoji themselves might display differently)
  • :auto mode: Set default Emoji mode for unknown/unsupported terminals to :none
  • Rename :basic mode to :vs16

3.0.1 (from changelog)

  • Add WezTerm and foot as good Emoji terminals

3.0.0 (from changelog)

Rework Emoji support:

  • Emoji widths are now enabled by default
  • Only reduce Emoji width to 2 when RGI Emoji detected (configurable)
  • VS16 turns Emoji characters of width 1 into full-width
  • Please note that Emoji parsing has a notable impact on performance. You can use the emoji: false option to disable Emoji adjustments
  • Tries to detect terminal's Emoji support level automatically (from ENV vars)

Index fixes and updates:

  • Private-use characters are considered ambiguous (were given width 1 before)
  • Fix that a few zero-width ignorable codepoints from recent Unicode were missing
  • Consider the following separators to be zero-width:
    • U+2028 - LINE SEPARATOR - Zl
    • U+2029 - PARAGRAPH SEPARATOR - Zp

Other:

  • Add keyword arguments to Unicode::DisplayWidth.of. If you are using a hash with overwrite values as third parameter, be sure to put it in curly braces.
  • Using third parameter or explicit hash as fourth parameter is deprecated, please migrate to the keyword arguments API
  • Gem raises ArgumentError for ambiguous values other than 1 or 2
  • Performance optimizations
  • Require Ruby 2.5

2.6.0 (from changelog)

  • Unicode 16

2.5.0 (from changelog)

  • Unicode 15.1

2.4.2 (from changelog)

More performance improvements:

  • Optimize lookup of first 4096 codepoints
  • Avoid overwrite lookup if no overwrites are set

2.4.1 (from changelog)

  • Improve general performance!
  • Further improve performance for ASCII strings

You should really upgrade - it's much faster now!

2.4.0 (from changelog)

  • Improve performance for ASCII-only strings, by @fatkodima
  • Require Ruby 2.4

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🆕 language_server-protocol (added, 3.17.0.3)

🆕 racc (added, 1.8.1)

🆕 unicode-emoji (added, 4.0.4)

🗑️ rexml (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 13, 2024
@depfu depfu bot assigned Narnach Dec 13, 2024
@depfu depfu bot requested a review from Narnach December 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant