Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffractedPlanewave objects can only be used with mode decomposition and not mode sources #2069

Closed
wants to merge 1 commit into from

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented May 12, 2022

Related to #2054.

Some of the (unrelated) changes are from rebuilding the documentation using make python_api_doc.

@stevengj
Copy link
Collaborator

Just to be clear, a DiffractedPlanewave specification is perfectly mathematically meaningful for an eigenmode source. However, most of the time you have an incident planewave you will only have a single incident planewave, and it's probably easier to just specify k_point … as long as the plane of incidence is oriented in the xy or xz plane so that you can use the parity feature to select the s or p polarization.

@stevengj
Copy link
Collaborator

We don't have a tutorial for using it as a source, which makes it harder to use, but I don't think we should remove it from the manual.

@stevengj stevengj closed this May 12, 2022
@oskooi oskooi deleted the diffpw_modedecomp_only branch May 12, 2022 02:10
@stevengj
Copy link
Collaborator

To launch a planewave at a particular angle, probably the easiest thing to do is to (a) from the angle and frequency, calculate the k_point, and (b) use a DiffractedPlanewave with order 0. (Basically, you are just using it to specify the s and p amplitudes conveniently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants