-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate material grid smoothing (β=∞) #1951
Draft
smartalecH
wants to merge
34
commits into
NanoComp:master
Choose a base branch
from
smartalecH:inf_smoothing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,330
−503
Draft
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5fd8cf6
subpixel averaging for boundaries of variable-material objects
stevengj d67b1f2
rm obsolete references to meepgeom::is_file
stevengj 6a9f7dd
bugfix
stevengj bf5296c
undo spurious change
stevengj a480ffd
add proper kernels for sphere caps
smartalecH 5c38aa7
clean up comments
smartalecH bb07eaa
checkpoint
smartalecH 92499af
merge in previous updates from subpixel_varmat
smartalecH 1652a62
minor tweaks to kill errors
smartalecH ee071de
enable smoothing
smartalecH b544afd
get gradients working both with and without averaging
smartalecH 5f59014
adjust FD step
smartalecH 8bfbb77
fix boundary case when spatial gradient doesn't exist
smartalecH 1880b0d
refactor
smartalecH fa35e16
add duals
smartalecH 3aa3c09
fix interface artifacts and get gradients working
smartalecH b1fd007
Merge branch 'master' of https://github.com/NanoComp/meep into inf_sm…
smartalecH 5c07d78
minor formatting
smartalecH 25f9437
update makefile
smartalecH b69a5d1
fix bug in fill fraction
smartalecH 69265e9
rebase
smartalecH 7a558fd
fix matgrid test bug
smartalecH 9ac153e
fix damping test failure
smartalecH 3349aee
revamp matgrid test and add comments
smartalecH 35ec6d8
update tests and add comments to code
smartalecH fabd531
approximate material-grid smoothing
stevengj 9793cf5
reformat
stevengj c88ca4a
rebase
smartalecH 83fd9ef
add function to update m number
smartalecH 2dff39e
update change m number too
smartalecH 2230adb
precommit cleanup
smartalecH 33ea63a
precommit cleanup
smartalecH 1d78417
incorporate m changes
smartalecH d3f5ef9
add threshold check for normal vector to mitigate floating point sens…
smartalecH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ numpy | |
parameterized | ||
pytest | ||
scipy | ||
scikit-fmm |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to include this additional module just for its signed distance function (rather than write our own or find a similar function in e.g. SciPy)? skfmm does not seem to be widely used which could make installing it a challenge for some users building from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From their docs:
What's challenging about this particular package vs
numpy
,scipy
, etc.?It's convenient for testing, but we can remove it if it really is a challenge to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into some package conflicts during the
pip install
. In general, it is useful to keep the number of package dependencies, particularly smaller ones, to a minimum.