Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor import resolution to use a global store #204

Merged
merged 14 commits into from
Dec 8, 2020
Merged

Refactor import resolution to use a global store #204

merged 14 commits into from
Dec 8, 2020

Commits on Dec 7, 2020

  1. Don't store internal structures of dhall in serde_dhall

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    697e93e View commit details
    Browse the repository at this point in the history

  2. Make global store of imports and import results

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    3a623ac View commit details
    Browse the repository at this point in the history

  3. Improve ergonomics of Ctxt

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    9991bd4 View commit details
    Browse the repository at this point in the history

  4. Thread cx through typecheck

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    6287b7a View commit details
    Browse the repository at this point in the history

  5. Thread cx through normalization

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    c785b7c View commit details
    Browse the repository at this point in the history

  6. Tag cx ids with the cx lifetime 

    To make sure we don't let ids escape and we don't mix scopes.
    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    3c52221 View commit details
    Browse the repository at this point in the history

  7. Thread cx everywhere else imports are read

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8c5b3ff View commit details
    Browse the repository at this point in the history

  8. Pass import results via the global context

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    c1fe26d View commit details
    Browse the repository at this point in the history

  9. Unify skip_resolve_expr with normal resolution

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    922199a View commit details
    Browse the repository at this point in the history

  10. Add tests

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    ff070d5 View commit details
    Browse the repository at this point in the history

  11. Avoid storing an import before we checked its hash

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    f478bc1 View commit details
    Browse the repository at this point in the history

  12. Defer name errors to typechecking 

    We aren't supposed to inspect anything before alternatives are chosen
    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    7a392b0 View commit details
    Browse the repository at this point in the history

  13. Resolve imports and alternatives outside of the ast traversal

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    4473f35 View commit details
    Browse the repository at this point in the history

  14. Soothe clippy

    @Nadrieril
    Nadrieril committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d0a6117 View commit details
    Browse the repository at this point in the history