Fix a bug in the implementation of constantSize().

Workaround a bad test. This test was never testing the c_if calls apparently. Signed-off-by: Eric Schweitz <[email protected]>
NVIDIA · Dec 13, 2024 · f12314f · f12314f
1 parent 08509fa
commit f12314f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/runtime/cudaq/builder/QuakeValue.cpp b/runtime/cudaq/builder/QuakeValue.cpp
@@ -190,7 +190,8 @@ QuakeValue QuakeValue::size() {
 
 std::optional<std::size_t> QuakeValue::constantSize() {
   if (auto qvecTy = dyn_cast<quake::VeqType>(getValue().getType()))
-    return qvecTy.getSize();
+     if (qvecTy.hasSpecifiedSize())
+	return qvecTy.getSize();
 
   return std::nullopt;
 }

diff --git a/unittests/Optimizer/QuakeSynthTester.cpp b/unittests/Optimizer/QuakeSynthTester.cpp
@@ -283,7 +283,10 @@ TEST(QuakeSynthTests, checkVectorOfInt) {
   kernel.h(aq);
   kernel.z(aq);
   kernel.h(q);
-  for (std::size_t i = 0; i < *q.constantSize(); ++i) {
+  // FIXME: This test never really tested the c_if in this loop. The call to
+  // constantSize just returned 0.
+  std::size_t unrollBy = q.constantSize().has_value() ? *q.constantSize() : 0;
+  for (std::size_t i = 0; i < unrollBy; ++i) {
     kernel.c_if(hiddenBits[i], [&]() { kernel.x<cudaq::ctrl>(aq, q[i]); });
   }
   kernel.h(q);