Apply suggestions from code review

Co-authored-by: Daniel Jünger <[email protected]>
NVIDIA · Nov 19, 2024 · a9027e4 · a9027e4
1 parent 29f5d27
commit a9027e4
Show file tree

Hide file tree

Showing 17 changed files with 21 additions and 21 deletions.
diff --git a/tests/static_map/capacity_test.cu b/tests/static_map/capacity_test.cu
@@ -18,7 +18,7 @@
 
 #include <catch2/catch_test_macros.hpp>
 
-TEST_CASE("static_map capacity", "")
+TEST_CASE("static_map capacity test", "")
 {
   using Key        = int32_t;
   using T          = int32_t;

diff --git a/tests/static_map/custom_type_test.cu b/tests/static_map/custom_type_test.cu
@@ -98,7 +98,7 @@ struct custom_key_equals {
   }
 };
 
-TEMPLATE_TEST_CASE_SIG("static_map custom key and value type",
+TEMPLATE_TEST_CASE_SIG("static_map custom key and value type tests",
                        "",
                        ((typename Key, typename Value), Key, Value),
 #if defined(CUCO_HAS_INDEPENDENT_THREADS)  // Key type larger than 8B only supported for sm_70 and

diff --git a/tests/static_map/heterogeneous_lookup_test.cu b/tests/static_map/heterogeneous_lookup_test.cu
@@ -82,7 +82,7 @@ struct custom_key_equal {
   }
 };
 
-TEMPLATE_TEST_CASE_SIG("static_map heterogeneous lookup",
+TEMPLATE_TEST_CASE_SIG("static_map heterogeneous lookup tests",
                        "",
                        ((typename T, int CGSize), T, CGSize),
 #if defined(CUCO_HAS_INDEPENDENT_THREADS)  // Key type larger than 8B only supported for sm_70 and

diff --git a/tests/static_map/insert_or_assign_test.cu b/tests/static_map/insert_or_assign_test.cu
@@ -71,7 +71,7 @@ void test_insert_or_assign(Map& map, size_type num_keys)
 }
 
 TEMPLATE_TEST_CASE_SIG(
-  "static_map insert_or_assign",
+  "static_map insert_or_assign tests",
   "",
   ((typename Key, typename Value, cuco::test::probe_sequence Probe, int CGSize),
    Key,

diff --git a/tests/static_map/rehash_test.cu b/tests/static_map/rehash_test.cu
@@ -22,7 +22,7 @@
 
 #include <catch2/catch_test_macros.hpp>
 
-TEST_CASE("static_map rehash", "")
+TEST_CASE("static_map rehash test", "")
 {
   using key_type    = int;
   using mapped_type = long;

diff --git a/tests/static_multimap/custom_pair_retrieve_test.cu b/tests/static_multimap/custom_pair_retrieve_test.cu
@@ -188,7 +188,7 @@ void test_non_shmem_pair_retrieve(Map& map, std::size_t const num_pairs)
 }
 
 TEMPLATE_TEST_CASE_SIG(
-  "static_multimap non-shared-memory pair_retrieve",
+  "static_multimap non-shared-memory pair_retrieve tests",
   "",
   ((typename Key, typename Value, cuco::test::probe_sequence Probe), Key, Value, Probe),
   (int32_t, int32_t, cuco::test::probe_sequence::linear_probing),

diff --git a/tests/static_multimap/custom_type_test.cu b/tests/static_multimap/custom_type_test.cu
@@ -208,7 +208,7 @@ void test_custom_key_value_type(Map& map, std::size_t num_pairs)
   }
 }
 
-TEMPLATE_TEST_CASE_SIG("static_multimap user defined key and value type",
+TEMPLATE_TEST_CASE_SIG("static_multimap user defined key and value type tests",
                        "",
                        ((cuco::test::probe_sequence Probe), Probe),
                        (cuco::test::probe_sequence::linear_probing),

diff --git a/tests/static_multimap/heterogeneous_lookup_test.cu b/tests/static_multimap/heterogeneous_lookup_test.cu
@@ -80,7 +80,7 @@ struct custom_key_equal {
   }
 };
 
-TEMPLATE_TEST_CASE("static_multimap heterogeneous lookup",
+TEMPLATE_TEST_CASE("static_multimap heterogeneous lookup tests",
                    "",
 #if defined(CUCO_HAS_INDEPENDENT_THREADS)  // Key type larger than 8B only supported for sm_70 and
                                            // up

diff --git a/tests/static_multimap/pair_function_test.cu b/tests/static_multimap/pair_function_test.cu
@@ -108,7 +108,7 @@ void test_pair_functions(Map& map, PairIt pair_begin, std::size_t num_pairs)
 }
 
 TEMPLATE_TEST_CASE_SIG(
-  "static_multimap pair functions",
+  "static_multimap pair functions tests",
   "",
   ((typename Key, typename Value, cuco::test::probe_sequence Probe), Key, Value, Probe),
   (int32_t, int32_t, cuco::test::probe_sequence::linear_probing),

diff --git a/tests/static_set/capacity_test.cu b/tests/static_set/capacity_test.cu
@@ -18,7 +18,7 @@
 
 #include <catch2/catch_test_macros.hpp>
 
-TEST_CASE("static_set capacity", "")
+TEST_CASE("static_set capacity test", "")
 {
   using Key        = int32_t;
   using ProbeT     = cuco::double_hashing<1, cuco::default_hash_function<Key>>;

diff --git a/tests/static_set/heterogeneous_lookup_test.cu b/tests/static_set/heterogeneous_lookup_test.cu
@@ -82,7 +82,7 @@ struct custom_key_equal {
   }
 };
 
-TEMPLATE_TEST_CASE_SIG("static_set heterogeneous lookup",
+TEMPLATE_TEST_CASE_SIG("static_set heterogeneous lookup tests",
                        "",
                        ((typename T, int CGSize), T, CGSize),
                        (int32_t, 1),

diff --git a/tests/static_set/rehash_test.cu b/tests/static_set/rehash_test.cu
@@ -21,7 +21,7 @@
 
 #include <catch2/catch_test_macros.hpp>
 
-TEST_CASE("static_set rehash", "")
+TEST_CASE("static_set rehash test", "")
 {
   using key_type = int;
 

diff --git a/tests/static_set/retrieve_test.cu b/tests/static_set/retrieve_test.cu
@@ -73,7 +73,7 @@ void test_unique_sequence(Set& set, std::size_t num_keys)
 }
 
 TEMPLATE_TEST_CASE_SIG(
-  "static_set retrieve",
+  "static_set retrieve tests",
   "",
   ((typename Key, cuco::test::probe_sequence Probe, int CGSize), Key, Probe, CGSize),
   (int32_t, cuco::test::probe_sequence::double_hashing, 1),

diff --git a/tests/static_set/shared_memory_test.cu b/tests/static_set/shared_memory_test.cu
@@ -64,7 +64,7 @@ __global__ void shared_memory_test_kernel(Ref* sets,
   }
 }
 
-TEMPLATE_TEST_CASE_SIG("static_set shared memory", "", ((typename Key), Key), (int32_t), (int64_t))
+TEMPLATE_TEST_CASE_SIG("static_set shared memory tests", "", ((typename Key), Key), (int32_t), (int64_t))
 {
   constexpr std::size_t number_of_sets  = 1000;
   constexpr std::size_t elements_in_set = 500;
@@ -187,7 +187,7 @@ __global__ void shared_memory_hash_set_kernel(bool* key_found)
   if (retrieved_it != find_ref.end() && *retrieved_it == rank) { key_found[index] = true; }
 }
 
-TEST_CASE("static_set shared memory slots.", "")
+TEST_CASE("static_set shared memory slots test", "")
 {
   constexpr std::size_t N = 256;
   [[maybe_unused]] auto constexpr num_windows =

diff --git a/tests/static_set/size_test.cu b/tests/static_set/size_test.cu
@@ -22,7 +22,7 @@
 
 #include <catch2/catch_test_macros.hpp>
 
-TEST_CASE("static_set size computation", "")
+TEST_CASE("static_set size test", "")
 {
   constexpr std::size_t num_keys{400};
 

diff --git a/tests/static_set/unique_sequence_test.cu b/tests/static_set/unique_sequence_test.cu
@@ -136,7 +136,7 @@ void test_unique_sequence(Set& set, size_type num_keys)
 }
 
 TEMPLATE_TEST_CASE_SIG(
-  "static_set unique sequence",
+  "static_set unique sequence tests",
   "",
   ((typename Key, cuco::test::probe_sequence Probe, int CGSize), Key, Probe, CGSize),
   (int32_t, cuco::test::probe_sequence::double_hashing, 1),

diff --git a/tests/utility/hash_test.cu b/tests/utility/hash_test.cu
@@ -67,7 +67,7 @@ __global__ void check_identity_hash_result_kernel(OutputIter result)
     cuda::std::numeric_limits<int64_t>::max(), cuda::std::numeric_limits<int64_t>::max());
 }
 
-TEST_CASE("utility cuco::identity_hash tests", "")
+TEST_CASE("utility cuco::identity_hash test", "")
 {
   SECTION("Check if host-generated hash values match the identity function.")
   {
@@ -121,7 +121,7 @@ __global__ void check_hash_result_kernel_64(OutputIter result)
     check_hash_result<cuco::xxhash_64<large_key<32>>>(123456789, 2031761887105658523, 0);
 }
 
-TEST_CASE("utility cuco::xxhash_64 tests", "")
+TEST_CASE("utility cuco::xxhash_64 test", "")
 {
   // Reference hash values were computed using https://github.com/Cyan4973/xxHash
   SECTION("Check if host-generated hash values match the reference implementation.")
@@ -184,7 +184,7 @@ __global__ void check_hash_result_kernel_32(OutputIter result)
   result[i++] = check_hash_result<cuco::xxhash_32<large_key<32>>>(123456789, 3715432378, 0);
 }
 
-TEST_CASE("utility cuco::xxhash_32 tests", "")
+TEST_CASE("utility cuco::xxhash_32 test", "")
 {
   // Reference hash values were computed using https://github.com/Cyan4973/xxHash
   SECTION("Check if host-generated hash values match the reference implementation.")
@@ -323,7 +323,7 @@ __global__ void check_murmurhash3_128_result_kernel(OutputIter result)
       1024);
 }
 
-TEST_CASE("utility cuco::murmurhash3_x64_128 tests", "")
+TEST_CASE("utility cuco::murmurhash3_x64_128 test", "")
 {
   // Reference hash values were computed using
   // https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp