Fix HyperConverged CR edits for OpenShift Virtualization #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
mikemckiernan
approved these changes
Nov 20, 2024
| pciDeviceSelector: 10DE:2236 | ||
| resourceName: nvidia.com/GA102GL_A10 | ||
| featureGates: | ||
| disableMdevConfiguration: true |
There was a problem hiding this comment.
Is there any chance that we can remove lines 86-91 that appear to reference similarly stale fields?
There was a problem hiding this comment.
Good point. Let me take a look and either remove it or modify those lines to use valid fields.
There was a problem hiding this comment.
I have updated the command called out in the prerequisite section. I have also switched to toggling the feature gate directly in the HyperConverged spec instead of applying the field indirectly through an annotation. This aligns with the instructions we currently have documented for KubeVirt: https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/latest/gpu-operator-kubevirt.html#prerequisites
cdesiniotis
force-pushed
the
fix-hyperconverged-cr
branch
2 times, most recently
from
b9df63b
to
a6080d1
Compare
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
fix-hyperconverged-cr
branch
from
a6080d1
to
658b094
Compare
mikemckiernan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.