Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong buffer for oneShotAllReduceKernel under PUSH_MODE #2099

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix wrong buffer for oneShotAllReduceKernel under PUSH_MODE #2099

wants to merge 3 commits into from

Commits on Aug 8, 2024

  1. fix bug: refer to the wrong buffer 

    `buffers[params.local_rank]` is not the buffer local to a gpu because `buffers` was shifted previously
    @YconquestY
    YconquestY committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    89023d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Merge branch 'NVIDIA:main' into main

    @YconquestY
    YconquestY authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ca34331 View commit details
    Browse the repository at this point in the history

  2. replace std::min with min inside CUDA kernel

    @YconquestY
    YconquestY committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6dfa8df View commit details
    Browse the repository at this point in the history