-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update front-page readme with link to XLA flag doc #684
base: main
Are you sure you want to change the base?
Conversation
Should we delete all xla flags from the front page readme, and link to this document and maybe the scripts for PAX or T5X for benchmark specific flags ? |
We need to tell which flag are enabled in the container. But maybe we can just list them and tell to see that page for their description? |
I think we should point to our scripts that enable these flags. Otherwise, there are duplicate documentation. Perhaps, the environment variables can stay here. |
Since the flags in there can change over time, what about instead including instructions to view the flags. Example:
|
That's a good idea. Let's do that. |
instructions for how to inspect them remotely
I would consider it a less-readable approach as a reader will have to break from the mental flow and do scripting to obtain these flags. A more user-friendly but also much heavier solution is to set up a proper docs building process (e.g. readthedocs) so that the docs page is automatically populated with the flags set in the containers. |
Maybe provide a sample output from one of our latest containers for now ? The flags are not going to change so rapidly and will atleast provide the users some idea of what is enabled for our benchmarks. |
Good point. @terrykong what do you think? |
Done 👍 |
Followup for #674 that links to this new document