-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cpp code path for Categorify
ops
#389
Conversation
Documentation preview |
the docs related errors are now resolved. There's two remaining things for this MR:
|
Thanks so much @oliverholworthy ! Sorry, I missed this earlier. |
Following the merge of NVIDIA-Merlin/NVTabular#1874 we're now getting a new error in the tests
|
I haven't had the time to understand the test failure well enough to work through a long-term fix. However, my last commit roles back the decision to use the cpp code path for "Categorify" by default. Instead, when the For example, you can enable the cpp version of
|
This is failing right now on some package mismatches right now. A solution is to update the tritonclient package to 2.30.0. Working on that solution now. Then we should be able to pick up the newest version of CI container to fix the triton errors. |
Rolls back one of the changes in #354 to improve inference performance of
Categorify
.