Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox environment dependencies configuration #1850

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update tox environment dependencies configuration #1850

wants to merge 7 commits into from
+25 −29

Conversation

oliverholworthy
Copy link
Member

@oliverholworthy oliverholworthy commented Jun 23, 2023 •
edited
Loading

Update tox environment dependencies. Simplifying the commands section of each environment

  • Moves all tox environment depdenencies into the deps configuration of each enivonment
  • Use MERLIN_BRANCH environment variable to configure the version of the merlin dependencies to fetch instead of passing this via posargs
    • posargs now used to specify the tests to run

@oliverholworthy oliverholworthy self-assigned this Jun 23, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/NVTabular/review/pr-1850

@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nv-alaiacano nv-alaiacano nv-alaiacano approved these changes

@karlhigley karlhigley karlhigley approved these changes

Assignees

@oliverholworthy oliverholworthy

Labels
chore ci
Projects
None yet
Milestone
Merlin 23.07
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverholworthy @karlhigley @nv-alaiacano