-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design of external storage + RocksDB interface #81
Open
bashimao
wants to merge
1
commit into
NVIDIA-Merlin:master
Choose a base branch
from
bashimao:fea-gds-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
bashimao
force-pushed
the
fea-gds-interface
branch
from
February 1, 2023 12:06
f93eadf
to
e79efa3
Compare
rhdong
reviewed
Feb 3, 2023
rhdong
reviewed
Feb 6, 2023
rhdong
reviewed
Feb 8, 2023
rhdong
reviewed
Feb 8, 2023
rhdong
reviewed
Feb 8, 2023
bashimao
force-pushed
the
fea-gds-interface
branch
2 times, most recently
from
February 9, 2023 02:37
eb42b56
to
b7907b5
Compare
bashimao
force-pushed
the
fea-gds-interface
branch
from
June 8, 2023 18:14
b7907b5
to
b5bce87
Compare
bashimao
changed the title
Design of GDS Interface
Design of external storage + RocksDB interface
Jun 8, 2023
@rhdong I changed the PR. See this as part 1 of the GDS interface . The external storage interface as specified now, will be used by the feeding process. |
RocksDB is downgraded to version 6.29 because that is the last version that doesn't yet require C++17. |
bashimao
force-pushed
the
fea-gds-interface
branch
from
June 9, 2023 09:11
b5bce87
to
7be9c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the MR. This now only contains the external storage interface + rocks db template implementation + tests.