Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a poll-based method for accepting TCP connections #43

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Use a poll-based method for accepting TCP connections #43

wants to merge 9 commits into from

Conversation

Bidski
Copy link
Contributor

@Bidski Bidski commented May 18, 2021

Addresses issue #17

@Bidski
Copy link
Contributor Author

Bidski commented May 18, 2021

@TrentHouliston and @CMurtagh-LGTM and @KipHamiltons this is currently untested. Just getting feedback before I go further

@CMurtagh-LGTM
Copy link
Contributor

Looks good

KipHamiltons
KipHamiltons reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@KipHamiltons KipHamiltons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't forget about this PR. The code looks fine, but whether it works is obviously the important thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KipHamiltons KipHamiltons KipHamiltons left review comments

@CMurtagh-LGTM CMurtagh-LGTM CMurtagh-LGTM left review comments

@TrentHouliston TrentHouliston Awaiting requested review from TrentHouliston

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bidski @CMurtagh-LGTM @KipHamiltons