Turn off clang tidy by default #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ endif() | |||
| set_project_warnings() | |||
|
|
|||
| # Default not to run the clang-tidy checks, default to whatever our CI_BUILD is | |||
| option(ENABLE_CLANG_TIDY "Enable building with clang-tidy checks." ON) | |||
| option(ENABLE_CLANG_TIDY "Enable building with clang-tidy checks." OFF) | |||
There was a problem hiding this comment.
Can you fix what makes it fail the first time?
There was a problem hiding this comment.
Im not entirely sure as I am not well versed in clang-tidy but correct me if I'm wrong, I remember these things having a warning-as-errors option that would cause compilation to fail because clang-tidy is complaining about stuff. Maybe this is somewhere along those lines and just disabling clang-tidy will make it go away perhaps?
There was a problem hiding this comment.
@KipHamiltons Can you elaborate, I'm not sure what you mean? Do you mean make it clang-tidy compliant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been sitting like this for ages and it causes compilation to fail for people setting it up for the first time. Might as well turn it off at this point.