[init] xml Styles 세팅 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
approved these changes
May 15, 2024
app/src/main/res/values/colors.xml
Outdated
Comment on lines
11
to
12
| <color name="yellow01">#F1F1EA</color> | ||
| <color name="red01">#F6EEED</color> |
There was a problem hiding this comment.
요 사이에도 한 줄 추가해주면 좋을 것 같습니다 ~
There was a problem hiding this comment.
아하~!! 넵 확인했습니다!!
app/src/main/res/values/colors.xml
Outdated
Comment on lines
16
to
19
| <color name="orange">#E76D55</color> | ||
| <color name="blue03">#EBF0F5</color> | ||
| <color name="purple">#7C72EE</color> | ||
| <color name="pink">#E36686</color> |
There was a problem hiding this comment.
여기도 통일성을 위해 한 줄 씩 추가해 줍시다 ~
app/src/main/res/values/colors.xml
Outdated
Comment on lines
41
to
46
| <color name="blue01">#297DCB</color> | ||
| <color name="blue02">#2588E4</color> | ||
| <color name="brown">#CC6E00</color> | ||
| <color name="red02">#EF6253</color> | ||
| <color name="green02">#00B856</color> | ||
| <color name="green03">#41B979</color> |
| <item name="android:includeFontPadding">false</item> | ||
| </style> | ||
|
|
||
| <!-- HEAD --> |
There was a problem hiding this comment.
Suggested change
| <!-- HEAD --> | |
| <!-- Head --> |
color와의 동일성을 유지하기 위해 이런 식으로 작성하는 게 좋을 것 같아요 ~
There was a problem hiding this comment.
오호! color와의 동일성을 생각 못했네요ㅎㅎㅎㅎ 요것도 수정하겠습니다 감사합니다😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢