Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressure masking netcdf modifying tool #43

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Pressure masking netcdf modifying tool #43

merged 12 commits into from
Apr 3, 2024

Conversation

ceblanton
Copy link
Collaborator

No description provided.

@ceblanton ceblanton requested a review from bcc2761 March 1, 2024 21:40
@ceblanton
Copy link
Collaborator Author

This is a neat self-contained tool that is useful to for FRE workflows, but it needs more documentation, tests, and it's not working perfectly yet in comparison to the Bronx refinediag script.

@bcc2761
Copy link
Contributor

bcc2761 commented Mar 4, 2024

@ceblanton I'm going to go in and change the argparse to click while I review this

@ceblanton ceblanton requested a review from chanwilson March 4, 2024 15:51
Copy link

@chanwilson chanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click is the way arguments are handled, not with argparse!

fre/freapp/maskAtmosPlevel.py Outdated Show resolved Hide resolved
@chanwilson
Copy link

I'm also not overjoyed about the qty of changes required when adding sub-commands, I have a couple thoughts on how to make that better.... but not for this PR.

@ceblanton
Copy link
Collaborator Author

This really needs a single pytest.

@bcc2761 bcc2761 merged commit a6748d1 into main Apr 3, 2024
2 checks passed
@bcc2761 bcc2761 deleted the mask-atmos-plevel branch May 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants