Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding notification for which directory cloned into #42

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

cwhitlock-NOAA
Copy link
Collaborator

No description provided.

@cwhitlock-NOAA
Copy link
Collaborator Author

Yes, it's just the print statement. It's a hello world for understanding the merge process.

@bcc2761
Copy link
Contributor

bcc2761 commented Mar 4, 2024

@cwhitlock-NOAA Sorry I didn't get back to you on Friday; I actually worked on a fix for this as soon as I saw your issue submitted, but I still want to get your merge in. Would you mind making a new commit with this change?

bcc2761@e48e227

Click prefers click.echo over print (reference: https://click.palletsprojects.com/en/8.1.x/quickstart/#echoing), and I thought that moving this notification to the end would be better than before the cloning occurs. Let me know if you have any thoughts

@cwhitlock-NOAA
Copy link
Collaborator Author

cwhitlock-NOAA commented Mar 4, 2024 via email

@bcc2761
Copy link
Contributor

bcc2761 commented Mar 4, 2024

Good point. I didn't account for failed clones that might confuse the user. Yeah, we can add it before the clone occurs then

@cwhitlock-NOAA cwhitlock-NOAA merged commit 27544c9 into main Mar 6, 2024
1 check passed
@cwhitlock-NOAA cwhitlock-NOAA deleted the 41.notify.dir branch March 6, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants