Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename fre/pp/*.py files to not clash with click cli command names. #279

Merged
merged 15 commits into from
Nov 27, 2024

Conversation

ilaflott
Copy link
Member

Describe your changes

see title

Issue ticket number and link (if applicable)

see PR #278

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@ilaflott ilaflott added bug Something isn't working enhancement New feature or request clean up labels Nov 27, 2024
@ilaflott ilaflott self-assigned this Nov 27, 2024
@ilaflott ilaflott requested a review from ceblanton November 27, 2024 15:53
@ilaflott ilaflott marked this pull request as ready for review November 27, 2024 16:10
@ilaflott
Copy link
Member Author

should be good!

the wrapper makes it to submitting jobs, unfortunately, the pp-starter jobs are failing.

@ceblanton ceblanton merged commit 2a49f1d into main Nov 27, 2024
2 checks passed
@ceblanton ceblanton deleted the fix_ambiguous_click_command_calls branch November 27, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clean up enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants