Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function check_multichunk to fix issue with chunk_freqs #701

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

jtmims
Copy link
Collaborator

@jtmims jtmims commented Oct 29, 2024

Description
The MDTF would run into an issue if multiple chunk_freqs would exist in a dataset. This new function checks to see if that is an issue. If it is, it grabs the grabs the files whose 'chunk_freq' is the largest number where endyr-startyr modulo chunk-freq is zero and throws out the rest.

Associated issue #700

How Has This Been Tested?
This has been tested with a CM4.5 dataset with the issue on the GFDL network. Various other non-problematic dataset were ran to insure the function doesn't overstep its bounds.

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

grammar grammar grammar
src/preprocessor.py Fixed Show fixed Hide fixed
@wrongkindofdoctor wrongkindofdoctor merged commit a278511 into NOAA-GFDL:main Oct 29, 2024
5 checks passed
@jtmims jtmims deleted the chunks branch October 29, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants