Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate standard names entry to fieldlists and varlistEntry objects #699

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description

  • define rainfall_flux and precipitation_flux entries in CMIP and GFDL fieldlists with new alternate_standard_names attribute
  • add alternate_standard_names to the translated_variable standard_name query
  • This may cause failure in the xr.parser reconcile var_names or attributes, so may need to iterate

Associated issue #698

How Has This Been Tested?
RHEL8, python 3.12

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

…MIP and GFDL fieldlists

add list of applicable realms to preciptitation flux
…endentvariable class that is VarlistEntry parent class

define realm parm as string or list
… the translation

add list to realm type hints in translation module
…L field tables since translator can't parse realm list correctly
@wrongkindofdoctor wrongkindofdoctor added framework Issue pertains to the framework code fieldlist The fieldlist tables are missing variables or have incorrect info data catalogs Issues related to intake esm data catalogs labels Oct 25, 2024
…ndard_name if the query standard name is a list with alternates instead of a string
@wrongkindofdoctor wrongkindofdoctor merged commit a383592 into NOAA-GFDL:main Oct 25, 2024
5 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the extend_alternates branch October 25, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data catalogs Issues related to intake esm data catalogs fieldlist The fieldlist tables are missing variables or have incorrect info framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants