Fix test failures with ifx due to use of host associated arrays

[abrooks1085]

Description
Adds save attribute to host associated arrays in test_topography and test_diag_integral so that these tests now pass with the ifx compiler.

How Has This Been Tested?
The Topography and Diag_integral unit tests successfully build and pass using the Intel oneAPI 2024.2 IFX compiler on an AMD box.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• New check tests, if applicable, are included
• make distcheck passes

[rem1776]

Just curious, what error is being fixed by adding the save attributes?

[bensonr]

Same question as @rem1776.

[laurenchilutti]

Can you rewrite this test to pass the arrays into the subroutines rather than keep them as program level variables? From our group discussions, this seems to be agreed upon as a path forward with this unit test.

[abrooks1085]

Updated my branch and removed the save attribute in favor of passing arrays to subroutine directly

[J-Lentz]

Why not get rid of initialize_arrays and initialize these in the declaration statements at the top of the program instead? As a bonus, that would give them an implicit save attribute.

[rem1776]

Should this test be updated like the other one to pass in the variables to each routine?

The only real change I'm seeing in this test is moving the intialize_arrays subroutine up in the file, which shouldn't change anything technically, but maybe ifx thinks otherwise.