Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement DY #2248

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Reimplement DY #2248

wants to merge 4 commits into from

Conversation

peterkrack
Copy link
Contributor

@peterkrack peterkrack commented Dec 11, 2024

Things to fix

DYE866_Z0_800GEV:

  • Central values differ.

DYE866_Z0_800GEV_DW_RATIO:

  • Different values for the rapidity.

DYE605_Z0_38P8GEV_DW:

  • 999 instead of 1000 replicas to determine uncertainties.

Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @peterkrack! Happy new year and thanks for this!

Here are some preliminary comments:

Could you please take of these first before I can move further into the details of the implementation?

@@ -0,0 +1,104 @@
from dataclasses import dataclass
from os import PathLike
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from os import PathLike

Remove PathLike and use only pathlib.Path.

import pandas as pd
import yaml

from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nnpdf_data.filter_utils.hera_utils.covmat_is_close is currently non-existing.

import pandas as pd
import yaml

from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close
from nnpdf_data.filter_utils.hera_utils import commondata

Same as above!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants