-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement DY #2248
base: master
Are you sure you want to change the base?
Reimplement DY #2248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterkrack! Happy new year and thanks for this!
Here are some preliminary comments:
- Could you please fix the metedata regarding the arXiv, inSpire, and HepData urls? These will be crucial when moving into Remove HepData raw tables from the repository #2228
- Could you make sure that the filters run properly. Currently, this is not the case as these filters contain some calls to non-existing functions.
- Add the following to the filters to properly format the floats:
nnpdf/nnpdf_data/nnpdf_data/commondata/ATHENA_NC_45GEV_EP/filter.py
Lines 12 to 14 in 3f59024
from nnpdf_data.filter_utils.utils import prettify_float yaml.add_representer(float, prettify_float) - Use pre-commit hooks https://pre-commit.com/ to make sure that all the files are properly formatted before each commit.
Could you please take of these first before I can move further into the details of the implementation?
@@ -0,0 +1,104 @@ | |||
from dataclasses import dataclass | |||
from os import PathLike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from os import PathLike |
Remove PathLike
and use only pathlib.Path
.
import pandas as pd | ||
import yaml | ||
|
||
from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nnpdf_data.filter_utils.hera_utils.covmat_is_close
is currently non-existing.
import pandas as pd | ||
import yaml | ||
|
||
from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from nnpdf_data.filter_utils.hera_utils import commondata, covmat_is_close | |
from nnpdf_data.filter_utils.hera_utils import commondata |
Same as above!
Things to fix
DYE866_Z0_800GEV:
DYE866_Z0_800GEV_DW_RATIO:
DYE605_Z0_38P8GEV_DW: