Merge pull request #77 from NJUCG/xiaoyaoing-patch-2

fix: fix a bug in PathIntegrator-new
NJUCG · Aug 7, 2023 · 93ddfab · 93ddfab
2 parents 20f1a04 + 3220f24
commit 93ddfab
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/FunctionLayer/Integrator/PathIntegrator-new.cpp b/src/FunctionLayer/Integrator/PathIntegrator-new.cpp
@@ -71,8 +71,9 @@ Spectrum PathIntegratorNew::Li(const Ray &initialRay,
 
         // Russian roulette.
         double pSurvive = russianRoulette(throughput, nBounces);
-        if (randFloat() > pSurvive)
+         if(sampler->sample1D()>=pSurvive){
             break;
+        }
         throughput /= pSurvive;
 
         //* ----- Direct Illumination -----
@@ -95,7 +96,7 @@ Spectrum PathIntegratorNew::Li(const Ray &initialRay,
 
         //*----- BSDF Sampling -----
         PathIntegratorLocalRecord sampleScatterRecord = sampleScatter(its, ray);
-        if (!sampleScatterRecord.f.isBlack()) {
+        if (!sampleScatterRecord.f.isBlack() && sampleScatterRecord.pdf!=0) {
             throughput *= sampleScatterRecord.f / sampleScatterRecord.pdf;
         } else {
             break;