Upgrade to Django 1.11 #126
Conversation
Alongwith Django 1.11, python-social-auth and Pillow have been upgraded. Fixes #108.
|
@nkprince007 is a newer version of coala fix the builds? |
| 'social_core.backends.google.GoogleOAuth2', | ||
| 'social_core.backends.google.GoogleOAuth', | ||
| 'social_core.backends.twitter.TwitterOAuth', | ||
| 'social_core.backends.yahoo.YahooOpenId', |
There was a problem hiding this comment.
why so many of these? Please remove the unnecessary ones. We only need google and facebook for now.
There was a problem hiding this comment.
Does having extra of these affect performance?
There was a problem hiding this comment.
@ankan17 no but we must have clarity on why we need these. This might confuse us in future. Please remove the Twitter etc.
| django-ckeditor==5.1.1 | ||
| django-email-extras==0.3.3 | ||
| django-forms-builder==0.13.0 | ||
| future==0.15.0 |
There was a problem hiding this comment.
why are these dependencies required?
| python3-openid==3.0.10 | ||
| pytz==2017.2 |
| django-forms-builder==0.13.0 | ||
| social-auth-app-django==1.2.0 | ||
| social-auth-core==1.3.0 | ||
| sphinx-me==0.3 |
There was a problem hiding this comment.
@ankan17 and why these new requirements? sphinx?
| social-auth-app-django==1.2.0 | ||
| social-auth-core==1.3.0 | ||
| sphinx-me==0.3 | ||
| Unidecode==0.4.20 |
| oauthlib==1.1.2 | ||
| Pillow==3.3.1 | ||
| olefile==0.44 | ||
| packaging==16.8 |
|
It should.
|
|
@ankan17 hey so can you update the version of coala too? |
|
@ankan17 please lock the coala and coala-bears packages to 0.10.
|
|
I have never used coala before.. I don't know how it is used! |
|
@ankan17 no need to change anything. Just put the latest version of coala in |
Alongwith Django 1.11, python-social-auth and Pillow have been upgraded.
Fixes #108.