Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.11 #108

Open
ghoshbishakh opened this issue Feb 8, 2017 · 13 comments
Open

Upgrade to 1.11 #108

ghoshbishakh opened this issue Feb 8, 2017 · 13 comments

Comments

@ghoshbishakh
Copy link
Member

@nkprince007 should we upgrade?

The changes required that I am aware of is python-sicual-auth

@nkprince007
Copy link
Member

Perhaps, defusedxml too?

@ghoshbishakh
Copy link
Member Author

@nkprince007 yes that is a necessity

@nkprince007
Copy link
Member

nkprince007 commented Feb 9, 2017

Pillow==4.0.0 seems to be required too. @ghoshbishakh

% ./manage.py makemigrations 
SystemCheckError: System check identified some issues:

ERRORS:
festflow.Event.logo: (fields.E210) Cannot use ImageField because Pillow is not installed.
	HINT: Get Pillow at https://pypi.python.org/pypi/Pillow or run command "pip install Pillow".
festflow.Keynote.image: (fields.E210) Cannot use ImageField because Pillow is not installed.
	HINT: Get Pillow at https://pypi.python.org/pypi/Pillow or run command "pip install Pillow".
festflow.organizerMember.avatar_img: (fields.E210) Cannot use ImageField because Pillow is not installed.
	HINT: Get Pillow at https://pypi.python.org/pypi/Pillow or run command "pip install Pillow".
festflow.sponsor.logo: (fields.E210) Cannot use ImageField because Pillow is not installed.
	HINT: Get Pillow at https://pypi.python.org/pypi/Pillow or run command "pip install Pillow".

% pip freeze | grep Pillow
Pillow==3.3.1

@ghoshbishakh
Copy link
Member Author

@nkprince007 pillow is required for what?

@nkprince007
Copy link
Member

@ghoshbishakh Pillow v4.0(python3.6) is required for ImageField.

@ghoshbishakh
Copy link
Member Author

@nkprince007 is it required for django 1.8 on py 3.6 or django 1.11?

@nkprince007
Copy link
Member

django 1.8 on python3.6 (fresh install of festcms)

@ghoshbishakh
Copy link
Member Author

@nkprince007 okay. So we need to add a test for django migrations in travis

@ghoshbishakh
Copy link
Member Author

@ankan17 can you possibly take up this task?

@ankan17
Copy link
Contributor

ankan17 commented May 25, 2017

Okk I'll try @ghoshbishakh

@ghoshbishakh
Copy link
Member Author

@ankan17 you will be facing problems with python social auth.

Just migrate that to the new version https://github.com/python-social-auth/social-app-django

@ankan17
Copy link
Contributor

ankan17 commented May 25, 2017

@ghoshbishakh Thanks for the heads up.. Anyway I'd have needed that for freepl as well.. :)

@ghoshbishakh
Copy link
Member Author

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants