Feature: Password based file encryption #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds encryption to uploaded files Fixes issue NITDgpOS#39
|
Hi. Thanks for contributing to PiZilla! 🎉 (Powered by GitMate.io) |
Adds encryption to uploaded files Fixes issue NITDgpOS#39
…4/PiZilla into feature/file-encryption
nkprince007
requested changes
Jan 1, 2018
| @@ -12,21 +13,35 @@ import webpackConfig from './../webpack.config.babel'; | |||
| const urlencodedParser = bodyparser.urlencoded({ extended: true }); | |||
| const isProduction = process.env.NODE_ENV === 'production'; | |||
| const entryPoint = isProduction ? '/build/' : 'http://localhost:8080/'; | |||
| const uploadDir = serverConfig.uploads; | |||
| const password = 'password'; | |||
There was a problem hiding this comment.
No, no, not a constant, this should be user configurable. Like suppose, when I upload a file and want it to be encrypted, I'll type in a password and share the URL and password with only one person. Only he / she who knows the password would be able to unzip it.
There was a problem hiding this comment.
Ok so I should take password from front-end right?
| @@ -38,6 +38,7 @@ | |||
| "eslint-plugin-react": "^7.3.0", | |||
| "express": "^4.15.4", | |||
| "file-loader": "^0.11.2", | |||
| "formidable": "^1.1.1", | |||
There was a problem hiding this comment.
you also need to kickout multer from dependencies. yarn remove multer
| uploadDir | ||
| }); | ||
| form.parse(req); | ||
| form.on('fileBegin', (name, file) => { |
There was a problem hiding this comment.
why do you have two event handlers for the same function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds encryption to uploaded files
Fixes issue #39