add browser based notifications #69
Conversation
ghost
assigned 
app/components/DropZone.jsx
Outdated
| @@ -3,6 +3,8 @@ import DropzoneComponent from 'react-dropzone-component'; | |||
| import FilesActions from './../actions/FilesActions'; | |||
| import PropTypes from 'prop-types'; | |||
|
|
|||
| Notification.requestPermission(); | |||
There was a problem hiding this comment.
The request for permission should be done in the constructor. Also, if the user has already rejected the permission, stop bugging him/her again.
There was a problem hiding this comment.
is there any advantage in doing so?
There was a problem hiding this comment.
We shouldn't write arbitrary code outside the react components. It is error-prone. It should be a part of the component life-cycle.
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
|
unack 1d40d26 Please address the requested changes. @pranay414 |
|
@nkprince007 I am not clear on what you mean by unack 1d40d26, can you explain it? |
|
Uhm, that's a part of GitMate.io application, that allows me to accept and reject commits with the commands And the bot is using my-account to post comments. So, it may seem like that I'm doing so, but it is infact a bot. |
Added browser based notifications on successful file upload Fixes issue #38
|
@gitmate-bot rebase. |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
|
Never merge I've rebased your PR with GitMate for now. But make sure you stick to that philosophy. Because most of the git based projects prefer linear commit history. Thanks for the PR, By the way 🎉 |
|
ack c54f575 |
Added browser based notifications on successful file upload
Fixes issue #38