Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack.config.babel.js : Changed output.publicPath and proxyed index #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2017

Requests from localhost:8080/bundle.js are routed to
localhost:8080/dev-server/bundle.js and requests from localhost:8080/
are proxyed to localhost:8000/. That is setting the output.publicPath
attribute to use /dev-server and then use a devServer.proxy attribute
to contain '/': 'http://localhost:8000/' as key value pair.

solves: #41

Requests  from localhost:8080/bundle.js are routed to
localhost:8080/dev-server/bundle.js and requests from localhost:8080/
are proxyed to localhost:8000/. That is setting the output publicPath
attribute to use /dev-server and then use a devServer.proxy attribute
to contain '/': 'http://localhost:8000/' as key value pair.

solves: #41
@ghost
Copy link
Author

ghost commented Dec 12, 2017

I made a new commit according to the guidelines. I did git commit --amend. For some reason, commits by another person were also included in my commit. (a few screenshots). Why did it happen?

@ghost ghost assigned nkprince007 Dec 12, 2017
@ghost ghost added the in progress label Dec 12, 2017
@nkprince007
Copy link
Member

shit.. I just merged an unwanted commit.

@nkprince007
Copy link
Member

Hey @ScareCROW21 can you please clean up your commit history by force pushing and use proper identity.

This commit has two authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants