Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index is proxyed and /dev-server added to output.publicPath #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

index is proxyed and /dev-server added to output.publicPath #67

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2017

Index is proxyed to localhost:8000
output.publicPath is set to /dev-server

@nkprince007
Copy link
Member

@ScareCROW21, the commit structure is too verbose. Simplify it a bit.

Follow this structure:

Shorlog: Basic Description

Detailed Description for the Commit

Fixes <issue_url>

@ghost
Copy link
Author

ghost commented Dec 3, 2017

git commit -m "shortlog , detailed description, fixes<issue_url>"
Do you want it to be like this?

I'm new to open source.

@nkprince007
Copy link
Member

No, no, it's different. Try git commit --amend, you'll be presented with an in terminal editor (vim or nano based on your configuration). You can then use it to edit the commit message.

For more details please visit http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html.

@nkprince007
Copy link
Member

@ScareCROW21, Since this is your first contribution to PiZilla, I'm exempting you from the commit message restrictions. But please follow then from the next time.

@nkprince007
Copy link
Member

You'd also need to change the line https://github.com/NITDgpOS/PiZilla/blob/master/server/routes.js#L35
to '/dev-server' + webpackConfig.output.filename for the second parameter to the url.resolve function.

This will let the client work in development mode.

@ghost
Copy link
Author

ghost commented Dec 4, 2017

Sorry. Will commit according to the guidelines next time.

routes.js: added '/dev-server' to second parameter in url.resolve

Line #35 is changed to `/dev-server/${webpackConfig.output.filename}`
for the second parameter to the url.resolve function.
This will let the client work in development mode.

Fixes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants