Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser based notifications #38

Open
nkprince007 opened this issue Oct 15, 2017 · 5 comments
Open

Browser based notifications #38

nkprince007 opened this issue Oct 15, 2017 · 5 comments

Comments

@nkprince007
Copy link
Member

Show browser based notifications on completion of file upload.

@nkprince007
Copy link
Member Author

nkprince007 commented Oct 15, 2017

https://github.com/georgeosddev/react-web-notification seems to be a great place to start with, especially since it's react again.

kudos++, if you could do this without adding a new dependency.

@pranay414
Copy link
Collaborator

@nkprince007 can you tell me which file deals with file upload?

@nkprince007
Copy link
Member Author

The backend is handled here: https://github.com/NITDgpOS/PiZilla/blob/master/server/routes.js#L16-L42

Once the upload has finished, this is where you can ask the client to push the notification.

@nkprince007
Copy link
Member Author

Actually, it's better and easier to use the HTML5 Notifications API directly. Refer MDN Docs on how to use it here.

@pranay414
Copy link
Collaborator

@nkprince007 please review my PR

nkprince007 pushed a commit that referenced this issue Dec 22, 2017
Added browser based notifications on successful file upload

Fixes issue #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants