Bugfix: GroupMap for new users

NIIF · Sep 21, 2019 · 3f78cb0 · 3f78cb0
1 parent 41bcfd2
commit 3f78cb0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -93,7 +93,3 @@ Shibboleth Single Logout (SLO) URL structure
 `$wgShibboleth_Logout_Base_Url . Shibboleth.sso/Logout?return= . $wgShibboleth_Logout_Target_Url`
 
 `https://wiki.example.org/Shibboleth.sso/Logout?return=https://wiki.example.org/index.php`
-
-## Known Bugs
-
-The very first time when the user authenticates with Shibboleth, **$wgShibboleth_GroupMap** does not take effect due [T184736](https://phabricator.wikimedia.org/T184736) bug. It requires a relogin (logout then login) to be able to map the given configuration.
diff --git a/Shibboleth.class.php b/Shibboleth.class.php
@@ -30,6 +30,13 @@ public function authenticate(&$id, &$username, &$realname, &$email, &$errorMessa
             $this->checkGroupMap();
         }
 
+        $user = User::newFromName($username);
+        $temporaryUserId = $user->getId();
+
+        if ($temporaryUserId !== 0) {
+          $id = $mId;
+        }
+
         return true;
     }