Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suspense to Router and Lazy loading of page components #42

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

imnotteixeira
Copy link
Collaborator

This change takes advantage of the recent React.lazy and React.Suspense APIs which allow us to load our components more selectively, relieving the end user from loading components he is not even looking at.

Extra: Added progress bars between page changes, it looks so good.

@imnotteixeira
Copy link
Collaborator Author

I would like to highlight that the Suspense API (required to use React.Lazy()) is still experimental, however, the usage of the lazy feature alone should be ok, the concurrent mode is the one that is still not ready yet. So this should be taken into account before merging.

@imnotteixeira imnotteixeira marked this pull request as draft April 14, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant