Feat/v3 #14
Merged
Feat/v3 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackmellis
force-pushed
the
feat/v3
branch
2 times, most recently
from
69f61fd to
29b9b74
Compare
For nftx v3 we're moving away from ethers.js and switching to viem + wagmi
For v3 we're running our own pricing router, instead of directly hitting sushi or routing via 0x
For asset metadata we've moved over from using opensea and alchemy to instead use reservoir
Pools in v3 are completely different in terms of concepts and implementation. So although we still have liquidity pools as before, they have been completely rewritten.
A new createQuery method now allows you to create statically typed queries and is how we will internally write most of our subgraph queries for v3
For v3 all buy/sell/swap actions are done via quotes. You request a quote for a transaction from the nftx api, then pass the quote data into the nftx.js method.
A new package, @nftx/errors allows for a much more fine grained error system and easier handling/recovering/displaying of errors in the UI
Trades in v3 can now be made via permit2. This allows you to make a single approval and then use permit2 to simply sign a transaction without paying gas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.