Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues mentioned in the audit #41

Open
wants to merge 15 commits into
base: feature/audit-pr
Choose a base branch
from

Conversation

apoorvlathey
Copy link
Member

@apoorvlathey apoorvlathey commented Nov 29, 2022

VaultCreationZap.sol

  • (High) Improper initialization used for upgradable contracts
  • (High) The CRYPTOPUNKS token cannot be transferred to the vault due to a lack of authorization
  • (High) Add liquidity feature will not work due to a lack of authorization

NFTXMarketplace0xZap.sol

  • (Info) Meaningless require code should be removed to keep the code logic clear
  • (Info) Add a check for the quoteAmount parameter to ensure users have enough vault tokens to redeem NFT tokens
  • (Info) Revoke allowances to improve security and compatibility
  • (Info) Spender variables are misused or misdescribed in multiple places

NFTXYieldStakingZap.sol

  • (High) Some issues about the buyAndStakeLiquidity() function
  • (Info) It is recommended to adjust the code structure to reduce user costs
  • (Info) Unused code

@apoorvlathey apoorvlathey marked this pull request as ready for review November 29, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants