Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deposit and Withdraw event for LP staking #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Deposit and Withdraw event for LP staking #40

wants to merge 6 commits into from

Conversation

tomwade
Copy link
Contributor

@tomwade tomwade commented Nov 21, 2022

No description provided.

@justincavery justincavery requested a review from 0xKiwi November 21, 2022 15:50
@0xKiwi 0xKiwi self-requested a review November 23, 2022 04:46
0xKiwi
0xKiwi suggested changes Nov 23, 2022
View reviewed changes
contracts/solidity/NFTXLPStaking.sol Outdated Show resolved Hide resolved
apoorvlathey
apoorvlathey requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@apoorvlathey apoorvlathey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deposit event missing in timelockDepositFor()

contracts/solidity/NFTXLPStaking.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xKiwi 0xKiwi 0xKiwi requested changes

@apoorvlathey apoorvlathey apoorvlathey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwade @0xKiwi @apoorvlathey