Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go in CI to 1.23 #104

Merged
merged 2 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.21
go-version: 1.23

- name: Vet
run: go vet ./...
Expand All @@ -35,6 +35,6 @@ jobs:
uses: goreleaser/goreleaser-action@v6
with:
version: latest
args: release --rm-dist
args: release --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.54
version: v1.61
5 changes: 5 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ issues:
- path: 'snmp/snmpwalk.go'
linters:
- funlen
- perfsprint
- path: 'snmp/util.go'
linters:
- perfsprint
- path: 'hp/mib/cpq_sm_cntrl.go'
linters:
- golint
Expand All @@ -43,6 +47,7 @@ linters:
- goerr113
- gofumpt
- gomnd
- mnd
- lll
- musttag
- nakedret
Expand Down
2 changes: 2 additions & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ func main() {
for _, controller := range controllers {
controllerStatus, desc := controller.GetNagiosStatus()
overall.Add(controllerStatus, desc)

countControllers++
}
}
Expand All @@ -173,6 +174,7 @@ func main() {
for _, drive := range drives {
driveStatus, desc := drive.GetNagiosStatus()
overall.Add(driveStatus, desc)

countDrives++
}
}
Expand Down
1 change: 1 addition & 0 deletions snmp/table.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ func SortOIDs(list []string) []string {
sort.Slice(list, func(i, j int) bool {
v1, _ := version.NewVersion(list[i])
v2, _ := version.NewVersion(list[j])

return v1.LessThan(v2)
})

Expand Down