Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify: logstash private key task #71

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Modify: logstash private key task #71

merged 4 commits into from
Jul 31, 2024

Conversation

Saeid-Abadi
Copy link
Contributor

No description provided.

@Saeid-Abadi Saeid-Abadi marked this pull request as ready for review July 31, 2024 07:20
Copy link
Member

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just came across the openssl_privatekey_convert module.
With that it should also be possible to convert the key to pkcs8. There is no module param to avoid a passphrase for the output key and the docs dont give that option too. But based on the code this should work when leaving the dest_passphrase empty.

With that we could avoid these ansible.builtin.command tasks. But thats only be cosmetic. For now the suggested PR will work.

@Saeid-Abadi Saeid-Abadi merged commit 1a5abe7 into main Jul 31, 2024
9 checks passed
@Saeid-Abadi Saeid-Abadi deleted the logstash-private-key branch July 31, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants