Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for Logstash 7 compatible keys #67

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Workaround for Logstash 7 compatible keys #67

merged 3 commits into from
Nov 13, 2023

Conversation

widhalmt
Copy link
Member

  • Add section in Readme about workarounds
  • Add a workaround that will create PKCS8 keys with valid encryption which can be read by Logstash 7

@widhalmt widhalmt added the feature New feature or request label Nov 13, 2023
@widhalmt widhalmt self-assigned this Nov 13, 2023
@widhalmt widhalmt enabled auto-merge (squash) November 13, 2023 14:33
afeefghannam89
afeefghannam89 reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@afeefghannam89 afeefghannam89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put one suggestion you can implement it or leave it.

tasks/main.yml Outdated Show resolved Hide resolved
afeefghannam89
afeefghannam89 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@afeefghannam89 afeefghannam89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas :) it looks ok

@widhalmt widhalmt merged commit 7c1231f into main Nov 13, 2023
9 checks passed
@widhalmt widhalmt deleted the fix/ls7-workaround branch November 13, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afeefghannam89 afeefghannam89 afeefghannam89 approved these changes

Assignees

@widhalmt widhalmt

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@widhalmt @afeefghannam89