Patch to use Python's tempfile library instead of 'temporary_file.temporary' #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances using the hardcoded path
temporary_file.temporary
can be problematic. For instance, if the starting directory for a Jupyter notebook instance is not writable by the user that started the notebook, trying to submit a fully typed out batch script will fail silently. There also may be contention issues in multi-user environments (i.e., a JupyterHub deployment) where multiple users start out in the same directory, since multiple users may try to write to the same temporary file at the same time.This patch tries to mitigate these issues by using Python's built-in
tempfile
library to systematically create tempfiles that are exclusively/uniquely allocated to individual users in a location that is known to be writable. Sincetempfile.mkstemp()
returns an absolute path in/tmp
(or the equivalent), there is no potential for an end-user to accidentally try to write to an unwritable directory.