Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and version bump 1.0.1 #100

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix and version bump 1.0.1 #100

merged 4 commits into from
Dec 4, 2024

Conversation

cbueth
Copy link
Collaborator

@cbueth cbueth commented Dec 4, 2024

This pull request includes a variety of changes across multiple files to enhance linting configurations, update documentation, and modify code for improved functionality and compatibility.

Versioning:

  • Updated the package version in superblockify/_version.py to 1.0.1.

Documentation Updates:

  • Added a new version entry (1.0.1) in docs/changelog.rst with details about lint reconfiguration, bug fixes, updates, and documentation improvements.
  • Modified docs/conf.py to dynamically update the copyright year using datetime.now().year and changed the release version to 1.0.1.

Code Enhancements:

  • Replaced unary_union with union_all in multiple files (docs/guide/31_tessellation.myst, docs/guide/32_edge_population.myst, examples/07-superblock-boundary.ipynb) to improve geometric operations. [1] [2] [3]
  • Updated docs/guide/30_population_density.myst and examples/06-population-density.ipynb to add a low_cutoff parameter to the get_population function, allowing for the exclusion of low population values. [1] [2]
  • Removing unused Haversine function, fixes How can solve: AttributeError: module 'osmnx' has no attribute 'project_gdf' #99.

Linting Configuration:

  • Updated .github/workflows/lint.yml to ignore additional pylint warnings R0917 for both source code and tests.

- `osmnx` does not expose `project_gdf()` to API anymore, use from submodule
- and replaced `unary_union` attribute with `union_all()`
- it used the lat-lng attributes which are no longer saved by default
- update test data
@cbueth cbueth self-assigned this Dec 4, 2024
- update docs/changelog.rst
- limit test steps to 1h
@cbueth cbueth force-pushed the 99-osmnx-project_gdf-api-change branch from 811a464 to de99e56 Compare December 4, 2024 09:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.54%. Comparing base (9fdc114) to head (de99e56).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
superblockify/population/tessellation.py 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   98.51%   98.54%   +0.03%     
==========================================
  Files          31       31              
  Lines        1885     1861      -24     
  Branches      448      333     -115     
==========================================
- Hits         1857     1834      -23     
  Misses          4        4              
+ Partials       24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbueth cbueth merged commit b2dbe3d into main Dec 4, 2024
58 checks passed
@cbueth cbueth deleted the 99-osmnx-project_gdf-api-change branch December 4, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can solve: AttributeError: module 'osmnx' has no attribute 'project_gdf'
2 participants