Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strive to enhance performance of the validation execution #28

Open
1 of 3 tasks
RichardBruskiewich opened this issue Aug 10, 2022 · 3 comments
Open
1 of 3 tasks

Strive to enhance performance of the validation execution #28

RichardBruskiewich opened this issue Aug 10, 2022 · 3 comments

Comments

@RichardBruskiewich
Copy link
Collaborator

RichardBruskiewich commented Aug 10, 2022 •
edited
Loading

Validation is getting a bit more sluggish with the extent of Biolink Model semantic validation now injected into the package.

Some ideas to explore:

  • Selectively disable Biolink Model validation by user-specified choice (if they don't want it) - Implemented in release v3.5.5
  • Identify opportunities for caching results of methods in various parts of the system
  • Can CodeDictionary access to codes and messages (and subtrees) be cached?
@RichardBruskiewich
Copy link
Collaborator Author

Eric's report on validation performance mainly seems to focus on TRAPI Schema validation being slow on large graphs?

@RichardBruskiewich RichardBruskiewich changed the title Strive to enhance performance of the validation Strive to enhance performance of the validation execution Aug 12, 2022
@kennethmorton
Copy link

Reasoner pydantic may offer some benefits for speed but it does not currently perform biolink model validation.

@RichardBruskiewich RichardBruskiewich mentioned this issue May 12, 2023
Closed
5 tasks
@RichardBruskiewich
Copy link
Collaborator Author

Overlap with #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RichardBruskiewich @kennethmorton